Providing they are suitable and embedding works, I prefer externally hosted pics. It saves the site bandwidth consumption. Just use the “Insert/edit image” icon, insert the URL of the image and the forum should embed it automatically.
With small photos, say up to 400KB, it maybe easier and more reliable to upload them.